Add request options bag to high level requests and include Meta #970
+882
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekistler
commented
Nov 17, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a RequestOptions class to consolidate common optional parameters (Meta, JsonSerializerOptions, and ProgressToken) across MCP client and server request methods. This refactoring reduces method signature complexity and enables setting the _meta field in requests, which is needed for new MCP spec features like SEP-1686 (Tasks).
Key Changes
- Added new
RequestOptionsclass to hold optional request parameters - Updated all client and server request method signatures to accept
RequestOptionsinstead of individual parameters - Created
PingRequestParamsprotocol class for structured ping requests - Updated tests to use the new method signatures with named parameters or null for options
Reviewed Changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ModelContextProtocol.Core/RequestOptions.cs | New options bag class with Meta, JsonSerializerOptions, and ProgressToken properties |
| src/ModelContextProtocol.Core/Protocol/PingRequestParams.cs | New protocol parameter class for ping requests |
| src/ModelContextProtocol.Core/Client/McpClient.Methods.cs | Updated all client methods to accept RequestOptions and properly set Meta in request params |
| src/ModelContextProtocol.Core/Server/McpServer.Methods.cs | Updated SampleAsync and RequestRootsAsync to accept RequestOptions |
| src/ModelContextProtocol.Core/Client/McpClientExtensions.cs | Updated extension methods to wrap individual parameters in RequestOptions |
| src/ModelContextProtocol.Core/Server/McpServerExtensions.cs | Updated extension methods to forward calls with named parameters |
| src/ModelContextProtocol.Core/Client/McpClient*.cs | Updated client wrapper classes to construct RequestOptions when calling client methods |
| src/ModelContextProtocol.Core/McpJsonUtilities.cs | Added PingRequestParams to source generation context |
| tests/**/*.cs | Updated all test call sites to use new signatures with null or named parameters |
| samples/**/*.cs | Updated sample code to use named parameters for cancellationToken |
tests/ModelContextProtocol.Tests/Client/McpClientExtensionsTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 20, 2025
stephentoub
reviewed
Nov 20, 2025
stephentoub
reviewed
Nov 20, 2025
stephentoub
reviewed
Nov 20, 2025
mikekistler
force-pushed
the
mdk/expose-meta
branch
from
dc24e39 to
4ed55e6
Compare
mikekistler
commented
Nov 24, 2025
mikekistler
commented
Nov 24, 2025
stephentoub
reviewed
Nov 24, 2025
mikekistler
commented
Nov 24, 2025
9 tasks
mikekistler
force-pushed
the
mdk/expose-meta
branch
from
4ed55e6 to
0792a65
Compare
Copilot finished reviewing on behalf of
mikekistler
December 2, 2025 16:00
stephentoub
reviewed
Dec 2, 2025
stephentoub
reviewed
Dec 2, 2025
sunnymitramsft
approved these changes
Dec 3, 2025
stephentoub
reviewed
Dec 3, 2025
stephentoub
reviewed
Dec 3, 2025
stephentoub
reviewed
Dec 3, 2025
stephentoub
reviewed
Dec 3, 2025
Contributor
|
#970 (comment) still needs to be addressed. Also there are conflicts that need to be resolved. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Stephen Toub <[email protected]>
mikekistler
force-pushed
the
mdk/expose-meta
branch
from
f517a94 to
06af40e
Compare
stephentoub
reviewed
Dec 4, 2025
stephentoub
reviewed
Dec 4, 2025
stephentoub
reviewed
Dec 4, 2025
stephentoub
reviewed
Dec 4, 2025
stephentoub
reviewed
Dec 4, 2025
stephentoub
approved these changes
Dec 4, 2025
jeffhandley
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds the ability to set fields of the
_metaparameter in requests with the high-level request methods.It also refactored these methods to move several parameters common in request methods -- JsonSerializerOptions, ProgressToken, and the new Meta field -- to an options bag to make these signatures more concise.
How Has This Been Tested?
All tests pass with the revised method signatures.
Breaking Changes
This will be breaking (as currently implemented) for users that specify any of these (uncommonly used) parameters.
Types of changes
Checklist
Additional context
Some new features in the 2025-11-25 version of the MCP spec require setting and reading fields of
_meta, e.g. SEP-1686: Tasks. This change will make it easier for users to access these new features.